From: Daniel P. Berrange <berrange@redhat.com>
Date: Wed, 18 Nov 2015 14:42:40 +0000 (+0000)
Subject: crypto: fix mistaken setting of Error in success code path
X-Git-Tag: TizenStudio_2.0_p2.3.2~120^2~1^2~53^2~2
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=6ef8cd7a4142049707b70b8278aaa9d8ee2bc5f5;p=sdk%2Femulator%2Fqemu.git

crypto: fix mistaken setting of Error in success code path

The qcrypto_tls_session_check_certificate() method was setting
an Error even when the ACL check suceeded. This didn't affect
the callers detection of errors because they relied on the
function return status, but this did cause a memory leak since
the caller would not free an Error they did not expect to be
set.

Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
---

diff --git a/crypto/tlssession.c b/crypto/tlssession.c
index ffc5c47..3735529 100644
--- a/crypto/tlssession.c
+++ b/crypto/tlssession.c
@@ -304,9 +304,9 @@ qcrypto_tls_session_check_certificate(QCryptoTLSSession *session,
 
                 allow = qemu_acl_party_is_allowed(acl, session->peername);
 
-                error_setg(errp, "TLS x509 ACL check for %s is %s",
-                           session->peername, allow ? "allowed" : "denied");
                 if (!allow) {
+                    error_setg(errp, "TLS x509 ACL check for %s is denied",
+                               session->peername);
                     goto error;
                 }
             }