From: Marc Zyngier <marc.zyngier@arm.com>
Date: Fri, 16 Mar 2018 14:35:17 +0000 (+0000)
Subject: irqchip/gic-v3: Loudly complain about the use of IRQ_TYPE_NONE
X-Git-Tag: v4.19~1188^2~8^2~8
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=6ef6386ef7c15bea21afce06f951c87de7e2a562;p=platform%2Fkernel%2Flinux-rpi.git

irqchip/gic-v3: Loudly complain about the use of IRQ_TYPE_NONE

There is a huge number of broken device trees out there. Just
grepping through the tree for the use of IRQ_TYPE_NONE in conjunction
with the GIC is scary.

People just don't realise that IRQ_TYPE_NONE just doesn't exist, and
you just get whatever junk was there before. So let's make them aware
of the issue.

Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
---

diff --git a/drivers/irqchip/irq-gic-v3.c b/drivers/irqchip/irq-gic-v3.c
index 3e9eeb6..5bb7bb2 100644
--- a/drivers/irqchip/irq-gic-v3.c
+++ b/drivers/irqchip/irq-gic-v3.c
@@ -916,6 +916,9 @@ static int gic_irq_domain_translate(struct irq_domain *d,
 		}
 
 		*type = fwspec->param[2] & IRQ_TYPE_SENSE_MASK;
+
+		/* Make it clear that broken DTs are... broken */
+		WARN_ON(*type == IRQ_TYPE_NONE);
 		return 0;
 	}
 
@@ -925,6 +928,8 @@ static int gic_irq_domain_translate(struct irq_domain *d,
 
 		*hwirq = fwspec->param[0];
 		*type = fwspec->param[1];
+
+		WARN_ON(*type == IRQ_TYPE_NONE);
 		return 0;
 	}