From: Alan Cox Date: Fri, 5 Oct 2012 00:13:42 +0000 (-0700) Subject: binfmt_elf: Uninitialized variable X-Git-Tag: upstream/snapshot3+hdmi~6530^2~101 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=6eec482f47a8e8888132b05575dea352187278cb;p=platform%2Fadaptation%2Frenesas_rcar%2Frenesas_kernel.git binfmt_elf: Uninitialized variable load_elf_interp() has interp_map_addr carefully described as "uninitialized_var" and marked so as to avoid a warning. However if you trace the code it is passed into load_elf_interp and then this value is checked against NULL. As this return value isn't used this is actually safe but it freaks various analysis tools that see un-initialized memory addresses being read before their value is ever defined. Set it to NULL as a matter of programming good taste if nothing else Signed-off-by: Alan Cox Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds --- diff --git a/fs/binfmt_elf.c b/fs/binfmt_elf.c index 0225fdd..7ef5f9f 100644 --- a/fs/binfmt_elf.c +++ b/fs/binfmt_elf.c @@ -881,7 +881,7 @@ static int load_elf_binary(struct linux_binprm *bprm, struct pt_regs *regs) } if (elf_interpreter) { - unsigned long uninitialized_var(interp_map_addr); + unsigned long interp_map_addr = 0; elf_entry = load_elf_interp(&loc->interp_elf_ex, interpreter,