From: Markus Armbruster Date: Fri, 13 Mar 2015 17:51:38 +0000 (+0100) Subject: block: Fix block-set-write-threshold not to use funky error class X-Git-Tag: TizenStudio_2.0_p2.3.2~208^2~292^2~2 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=6ec46ad541b20a1530cedc741d19eea9ffc39ac3;p=sdk%2Femulator%2Fqemu.git block: Fix block-set-write-threshold not to use funky error class Error classes are a leftover from the days of "rich" error objects. New code should always use ERROR_CLASS_GENERIC_ERROR. Commit e246211 added a use of ERROR_CLASS_DEVICE_NOT_FOUND. Replace it. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Signed-off-by: Kevin Wolf --- diff --git a/block/write-threshold.c b/block/write-threshold.c index c2cd517..a53c1f5 100644 --- a/block/write-threshold.c +++ b/block/write-threshold.c @@ -112,7 +112,7 @@ void qmp_block_set_write_threshold(const char *node_name, bs = bdrv_find_node(node_name); if (!bs) { - error_set(errp, QERR_DEVICE_NOT_FOUND, node_name); + error_setg(errp, "Device '%s' not found", node_name); return; } diff --git a/qapi/block-core.json b/qapi/block-core.json index 90586a5..42c8850 100644 --- a/qapi/block-core.json +++ b/qapi/block-core.json @@ -1961,10 +1961,6 @@ # @write-threshold: configured threshold for the block device, bytes. # Use 0 to disable the threshold. # -# Returns: Nothing on success -# If @node name is not found on the block device graph, -# DeviceNotFound -# # Since: 2.3 ## { 'command': 'block-set-write-threshold',