From: Shenwei Wang Date: Fri, 12 May 2023 13:38:43 +0000 (-0500) Subject: net: fec: remove the xdp_return_frame when lack of tx BDs X-Git-Tag: v6.6.17~4848^2~27 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=6ead9c98cafcbc6992cf35f0ca393df2c03e3316;p=platform%2Fkernel%2Flinux-rpi.git net: fec: remove the xdp_return_frame when lack of tx BDs In the implementation, the sent_frame count does not increment when transmit errors occur. Therefore, bq_xmit_all() will take care of returning the XDP frames. Fixes: 26312c685ae0 ("net: fec: correct the counting of XDP sent frames") Signed-off-by: Shenwei Wang Reviewed-by: Horatiu Vultur Signed-off-by: David S. Miller --- diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c index 241df41..577d948 100644 --- a/drivers/net/ethernet/freescale/fec_main.c +++ b/drivers/net/ethernet/freescale/fec_main.c @@ -3798,7 +3798,6 @@ static int fec_enet_txq_xmit_frame(struct fec_enet_private *fep, entries_free = fec_enet_get_free_txdesc_num(txq); if (entries_free < MAX_SKB_FRAGS + 1) { netdev_err(fep->netdev, "NOT enough BD for SG!\n"); - xdp_return_frame(frame); return NETDEV_TX_BUSY; }