From: jaehoon.you Date: Wed, 9 Jan 2013 06:54:42 +0000 (+0900) Subject: [Prevent] fix Tizen 35853, and update authors list X-Git-Tag: submit/tizen_2.1/20130425.000057^2~5 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=6ea6a360fa75766b6e56545486e685ccd552ebab;p=tools%2Flthor.git [Prevent] fix Tizen 35853, and update authors list Tizen 35853 : DEADCODE original code is "assert(chunksize > 0 && chunksize <= trans_unit_size);" (reference send_chunks() : line 125) but chunksize already checked before line:1086 (chunksize <= 0) then, chunksize always bigger than 0 . so, exclamation mark is moved to another location and conditional sentence is switched. Change-Id: I9e5a2f998fb506fd152da856f4c9455f027207a6 Signed-off-by: jaehoon.you --- diff --git a/lthor.c b/lthor.c index c4937d3..27df43d 100755 --- a/lthor.c +++ b/lthor.c @@ -1100,7 +1100,7 @@ int test_tar_entry(struct data_src *tardata) return -1; } - if ((!chunksize > 0 && chunksize <= trans_unit_size)) { + if (!(chunksize <= trans_unit_size && chunksize > 0)) { free(chunk); return -1; } @@ -1190,7 +1190,8 @@ int main(int argc, char **argv) printf("\n"); printf("Linux Thor downloader, version %s \n", PACKAGE_VERSION); - printf("Authors: YoungJin Lee \n\n"); + printf("Authors: YoungJin Lee , " + "Jaehoon You \n\n"); while (opt < argc) { /* check if we're verbose */