From: Christoph Hellwig <hch@lst.de>
Date: Wed, 13 May 2020 11:07:59 +0000 (+0200)
Subject: net: ignore sock_from_file errors in __scm_install_fd
X-Git-Tag: v5.15~3723^2~207
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=6e8a4f9dda3823274fa8a4c1aa5e6a93f9775749;p=platform%2Fkernel%2Flinux-starfive.git

net: ignore sock_from_file errors in __scm_install_fd

The code had historically been ignoring these errors, and my recent
refactoring changed that, which broke ssh in some setups.

Fixes: 2618d530dd8b ("net/scm: cleanup scm_detach_fds")
Reported-by: Ido Schimmel <idosch@idosch.org>
Signed-off-by: Christoph Hellwig <hch@lst.de>
Tested-by: Ido Schimmel <idosch@mellanox.com>
Tested-by: Ioana Ciornei <ioana.ciornei@nxp.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
---

diff --git a/net/core/scm.c b/net/core/scm.c
index a75cd63..875df1c 100644
--- a/net/core/scm.c
+++ b/net/core/scm.c
@@ -307,7 +307,7 @@ static int __scm_install_fd(struct file *file, int __user *ufd, int o_flags)
 		sock_update_classid(&sock->sk->sk_cgrp_data);
 	}
 	fd_install(new_fd, get_file(file));
-	return error;
+	return 0;
 }
 
 static int scm_max_fds(struct msghdr *msg)