From: Jakub Kicinski Date: Thu, 20 Dec 2018 06:13:07 +0000 (-0800) Subject: nfp: bpf: remove the trivial JSET optimization X-Git-Tag: v5.15~7332^2~15^2~2^2~2 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=6e774845b321e729966fed7de4aa8ea59c2c3b2e;p=platform%2Fkernel%2Flinux-starfive.git nfp: bpf: remove the trivial JSET optimization The verifier will now understand the JSET instruction, so don't mark the dead branch in the JIT as noop. We won't generate any code, anyway. Signed-off-by: Jakub Kicinski Reviewed-by: Quentin Monnet Signed-off-by: Daniel Borkmann --- diff --git a/drivers/net/ethernet/netronome/nfp/bpf/jit.c b/drivers/net/ethernet/netronome/nfp/bpf/jit.c index 662cbc2..f765e76 100644 --- a/drivers/net/ethernet/netronome/nfp/bpf/jit.c +++ b/drivers/net/ethernet/netronome/nfp/bpf/jit.c @@ -3054,11 +3054,6 @@ static int jset_imm(struct nfp_prog *nfp_prog, struct nfp_insn_meta *meta) u64 imm = insn->imm; /* sign extend */ swreg tmp_reg; - if (!imm) { - meta->skip = true; - return 0; - } - if (imm & ~0U) { tmp_reg = ur_load_imm_any(nfp_prog, imm & ~0U, imm_b(nfp_prog)); emit_alu(nfp_prog, reg_none(),