From: Luis de Bethencourt Date: Mon, 29 Jun 2015 15:16:06 +0000 (+0100) Subject: videoscaler: remove check for below zero for unsigned value X-Git-Tag: 1.19.3~511^2~3494 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=6e263cc5f64710fc09198a763244cbd4ac82fab6;p=platform%2Fupstream%2Fgstreamer.git videoscaler: remove check for below zero for unsigned value CLAMP checks both if value is '< 0' and '> max'. Value will never be a negative number since it is a division of an unsigned integer (i). Removing that check and only checking if it is bigger than max and setting it appropriately. CID #1308950 --- diff --git a/gst-libs/gst/video/video-scaler.c b/gst-libs/gst/video/video-scaler.c index 4bc156c..6b06c1d 100644 --- a/gst-libs/gst/video/video-scaler.c +++ b/gst-libs/gst/video/video-scaler.c @@ -1145,12 +1145,12 @@ gst_video_scaler_combine_packed_YUV (GstVideoScaler * y_scale, gint ic; if ((i & 1) == scale->out_y_offset) { - ic = CLAMP (i / 2, 0, y_scale->resampler.out_size - 1); + ic = MIN (i / 2, y_scale->resampler.out_size - 1); offset[i] = y_scale->resampler.offset[ic] * 2 + scale->in_y_offset; memcpy (taps + i * max_taps, y_scale->resampler.taps + y_scale->resampler.phase[ic] * max_taps, max_taps * sizeof (gdouble)); } else { - ic = CLAMP (i / 4, 0, uv_scale->resampler.out_size - 1); + ic = MIN (i / 4, uv_scale->resampler.out_size - 1); offset[i] = uv_scale->resampler.offset[ic] * 4 + (i & 3); memcpy (taps + i * max_taps, uv_scale->resampler.taps + uv_scale->resampler.phase[ic] * max_taps,