From: Greg Kroah-Hartman <gregkh@suse.de>
Date: Fri, 31 Mar 2006 23:37:06 +0000 (-0800)
Subject: [PATCH] sysfs: zero terminate sysfs write buffers
X-Git-Tag: v2.6.17-rc1~7
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=6e0dd741a89be35defa05bd79f4211c5a2762825;p=platform%2Fkernel%2Flinux-exynos.git

[PATCH] sysfs: zero terminate sysfs write buffers

No one should be writing a PAGE_SIZE worth of data to a normal sysfs
file, so properly terminate the buffer.

Thanks to Al Viro for pointing out my supidity here.

Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
---

diff --git a/fs/sysfs/file.c b/fs/sysfs/file.c
index 830f76fa..f1cb1dd 100644
--- a/fs/sysfs/file.c
+++ b/fs/sysfs/file.c
@@ -183,7 +183,7 @@ fill_write_buffer(struct sysfs_buffer * buffer, const char __user * buf, size_t
 		return -ENOMEM;
 
 	if (count >= PAGE_SIZE)
-		count = PAGE_SIZE;
+		count = PAGE_SIZE - 1;
 	error = copy_from_user(buffer->page,buf,count);
 	buffer->needs_read_fill = 1;
 	return error ? -EFAULT : count;