From: Wonki Kim Date: Tue, 27 Aug 2019 04:27:54 +0000 (+0900) Subject: eina_list: fix to check a null argument X-Git-Tag: accepted/tizen/unified/20190828.010608~1 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=6dbae67ac5da6813767fd3d9642c41a8e6ba7aa6;p=platform%2Fupstream%2Fefl.git eina_list: fix to check a null argument Summary: data should be checked regardless of EINA_MAGIC define, because it is dereferenced in the following logic. Reviewers: cedric, bu5hm4n Subscribers: #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D9750 Change-Id: I74d97bda83dd45444bade5c0ae1066292ebadfd4 --- diff --git a/src/lib/eina/eina_list.c b/src/lib/eina/eina_list.c index 2e7e24c..a9857bf 100644 --- a/src/lib/eina/eina_list.c +++ b/src/lib/eina/eina_list.c @@ -959,6 +959,7 @@ eina_list_move_list(Eina_List **to, Eina_List **from, Eina_List *data) { EINA_SAFETY_ON_NULL_RETURN_VAL(to, EINA_FALSE); EINA_SAFETY_ON_NULL_RETURN_VAL(from, EINA_FALSE); + EINA_SAFETY_ON_NULL_RETURN_VAL(data, EINA_FALSE); #ifdef EINA_LIST_MAGIC if (*to) EINA_MAGIC_CHECK_LIST(*to, EINA_FALSE);