From: Edward Hervey Date: Wed, 3 Jan 2018 15:02:08 +0000 (+0100) Subject: amrwbdec: Don't use g_return_*_if_fail() on data parsing X-Git-Tag: 1.16.2~78 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=6da70e278a5683d4e776edc25043f2c5d0a2a302;p=platform%2Fupstream%2Fgst-plugins-ugly.git amrwbdec: Don't use g_return_*_if_fail() on data parsing Those functions can be disabled. Instead just use the (existing) function. CID #1427093 --- diff --git a/ext/amrwbdec/amrwbdec.c b/ext/amrwbdec/amrwbdec.c index f90b7b7..cf05d95 100644 --- a/ext/amrwbdec/amrwbdec.c +++ b/ext/amrwbdec/amrwbdec.c @@ -172,14 +172,12 @@ gst_amrwbdec_parse (GstAudioDecoder * dec, GstAdapter * adapter, gint block, mode; size = gst_adapter_available (adapter); - g_return_val_if_fail (size > 0, GST_FLOW_ERROR); + if (size < 1) + return GST_FLOW_ERROR; gst_audio_decoder_get_parse_state (dec, &sync, &eos); /* need to peek data to get the size */ - if (size < 1) - return GST_FLOW_ERROR; - gst_adapter_copy (adapter, header, 0, 1); mode = (header[0] >> 3) & 0x0F; block = block_size[mode];