From: Fangrui Song <maskray@google.com>
Date: Tue, 25 Sep 2018 02:50:57 +0000 (+0000)
Subject: Remove redundant null pointer check in operator delete
X-Git-Tag: llvmorg-8.0.0-rc1~8048
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=6da5366ea9f92c1318a8b360062668c8e25a08e8;p=platform%2Fupstream%2Fllvm.git

Remove redundant null pointer check in operator delete

C89 4.10.3.2 The free function
C99 7.20.3.2 The free function
C11 7.22.3.3 The free function

    If ptr is a null pointer, no action shall occur.

_aligned_free on MSDN:

    If memblock is a NULL pointer, this function simply performs no actions.

Reviewers: EricWF, mclow.lists

Subscribers: christof, ldionne, cfe-commits, libcxx-commits

Differential Revision: https://reviews.llvm.org/D52401

llvm-svn: 342936
---

diff --git a/libcxx/src/new.cpp b/libcxx/src/new.cpp
index 8013d89..35f481d 100644
--- a/libcxx/src/new.cpp
+++ b/libcxx/src/new.cpp
@@ -135,8 +135,7 @@ _LIBCPP_WEAK
 void
 operator delete(void* ptr) _NOEXCEPT
 {
-    if (ptr)
-        ::free(ptr);
+    ::free(ptr);
 }
 
 _LIBCPP_WEAK
@@ -257,11 +256,10 @@ _LIBCPP_WEAK
 void
 operator delete(void* ptr, std::align_val_t) _NOEXCEPT
 {
-    if (ptr)
 #if defined(_LIBCPP_MSVCRT_LIKE)
-        ::_aligned_free(ptr);
+    ::_aligned_free(ptr);
 #else
-        ::free(ptr);
+    ::free(ptr);
 #endif
 }