From: Matthias Clasen Date: Thu, 19 Apr 2012 17:25:26 +0000 (-0400) Subject: Revert "tests: fix test on windows" X-Git-Tag: 2.33.1~68 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=6d51527ba0fe7cece9d1f61466076d332bc7fbac;p=platform%2Fupstream%2Fglib.git Revert "tests: fix test on windows" This reverts commit 79361eede240e9591891290c22cd072ccddb78a3. Just commenting out a test without an explanation does not look right to me. This needs at the minimum a link to a bug report or an explanation for why the behaviour is platform dependent. If the test was just wrong, it needs to be removed, not commented out. If there is a bug in the win32 implementation, it needs to be fixed. --- diff --git a/glib/tests/fileutils.c b/glib/tests/fileutils.c index 40ecdd4..ebc62af 100644 --- a/glib/tests/fileutils.c +++ b/glib/tests/fileutils.c @@ -254,7 +254,7 @@ test_build_filename (void) /* Test also using the slash as file name separator */ #define U "/" -/* check_string (g_build_filename (NULL), "");*/ + check_string (g_build_filename (NULL), ""); check_string (g_build_filename (U, NULL), U); check_string (g_build_filename (U"x", NULL), U"x"); check_string (g_build_filename ("x"U, NULL), "x"U);