From: Vincent Penquerc'h <vincent.penquerch@collabora.co.uk>
Date: Tue, 10 Jan 2012 13:25:05 +0000 (+0000)
Subject: interlace: fix caps leaks
X-Git-Tag: 1.19.3~507^2~15870^2~2
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=6cf84a0348d49e2906451b251d1e09387b1199a6;p=platform%2Fupstream%2Fgstreamer.git

interlace: fix caps leaks
---

diff --git a/gst/interlace/gstinterlace.c b/gst/interlace/gstinterlace.c
index 4e224be7b1..96455f1a24 100644
--- a/gst/interlace/gstinterlace.c
+++ b/gst/interlace/gstinterlace.c
@@ -187,6 +187,7 @@ static gboolean gst_interlace_setcaps (GstPad * pad, GstCaps * caps);
 static GstCaps *gst_interlace_getcaps (GstPad * pad);
 static GstStateChangeReturn gst_interlace_change_state (GstElement * element,
     GstStateChange transition);
+static void gst_interlace_finalize (GObject * obj);
 
 static GstElementClass *parent_class = NULL;
 
@@ -242,6 +243,7 @@ gst_interlace_class_init (GstInterlaceClass * klass)
 
   object_class->set_property = gst_interlace_set_property;
   object_class->get_property = gst_interlace_get_property;
+  object_class->finalize = gst_interlace_finalize;
 
   element_class->change_state = gst_interlace_change_state;
 
@@ -268,6 +270,16 @@ gst_interlace_class_init (GstInterlaceClass * klass)
 
 }
 
+static void
+gst_interlace_finalize (GObject * obj)
+{
+  GstInterlace *interlace = GST_INTERLACE (obj);
+
+  gst_caps_replace (&interlace->srccaps, NULL);
+
+  G_OBJECT_CLASS (parent_class)->finalize (obj);
+}
+
 static void
 gst_interlace_reset (GstInterlace * interlace)
 {
@@ -478,7 +490,7 @@ gst_interlace_setcaps (GstPad * pad, GstCaps * caps)
   gboolean interlaced = TRUE;
   int fps_n, fps_d;
   GstPad *otherpad;
-  GstCaps *othercaps;
+  GstCaps *othercaps = NULL;
   const PulldownFormat *pdformat;
 
   interlace = GST_INTERLACE (gst_pad_get_parent (pad));
@@ -527,6 +539,8 @@ gst_interlace_setcaps (GstPad * pad, GstCaps * caps)
   }
 
 error:
+  if (othercaps)
+    gst_caps_unref (othercaps);
   g_object_unref (interlace);
 
   return ret;