From: Christopher Michael Date: Thu, 2 May 2019 12:11:12 +0000 (+0200) Subject: eina_test_tiler: Fix resource leak X-Git-Tag: accepted/tizen/unified/20190509.041000~45 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=6cd273da934acd21e28e9216dfe851c062775fa8;p=platform%2Fupstream%2Fefl.git eina_test_tiler: Fix resource leak Summary: Coverity reports that reassigning 't' here leaks the storage that t points to, so free the previous eina_tiler before reassigning the variable. Fixes CID1401068 @fix Reviewers: raster, cedric, zmike, bu5hm4n, segfaultxavi Reviewed By: segfaultxavi Subscribers: segfaultxavi, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D8762 --- diff --git a/src/tests/eina/eina_test_tiler.c b/src/tests/eina/eina_test_tiler.c index 46d1b02..e2f1adb 100644 --- a/src/tests/eina/eina_test_tiler.c +++ b/src/tests/eina/eina_test_tiler.c @@ -245,12 +245,8 @@ EFL_START_TEST(eina_test_tiler_calculation) t2 = eina_tiler_new(500, 500); fail_if(!t2); - t = eina_tiler_new(500, 500); - fail_if(!t); - eina_tiler_tile_size_set(t1, 1, 1); eina_tiler_tile_size_set(t2, 1, 1); - eina_tiler_tile_size_set(t, 1, 1); EINA_RECTANGLE_SET(&r1, 0, 0, 500, 500); eina_tiler_rect_add(t1, &r1);