From: Roland Scheidegger Date: Mon, 1 Jan 2018 18:40:56 +0000 (+0100) Subject: r600: don't use vtx offset for load_sample_position X-Git-Tag: upstream/18.1.0~2822 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=6c8d6ce982d3ce9dfde02a59db23b138df26ae55;p=platform%2Fupstream%2Fmesa.git r600: don't use vtx offset for load_sample_position The offset looks bogus to me. Albeit in the end it doesn't matter, by the looks of it offsets smaller than 4 get ignored there (not sure of the rules, I suppose either non-dword aligned offsets never work there or the offset must be at least aligned to the size of a single element). Tested-by: Konstantin Kharlamov Reviewed-by: Dave Airlie --- diff --git a/src/gallium/drivers/r600/r600_shader.c b/src/gallium/drivers/r600/r600_shader.c index f6ff205..bb7cc17 100644 --- a/src/gallium/drivers/r600/r600_shader.c +++ b/src/gallium/drivers/r600/r600_shader.c @@ -1284,7 +1284,7 @@ static int load_sample_position(struct r600_shader_ctx *ctx, struct r600_shader_ vtx.num_format_all = 2; vtx.format_comp_all = 1; vtx.use_const_fields = 0; - vtx.offset = 1; // first element is size of buffer + vtx.offset = 0; vtx.endian = r600_endian_swap(32); vtx.srf_mode_all = 1; /* SRF_MODE_NO_ZERO */