From: bhutani.92 Date: Tue, 20 Dec 2016 12:40:36 +0000 (+0530) Subject: [TSAM-11769] Fixed double free issue X-Git-Tag: submit/tizen_3.0/20161220.124212^0 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=6c8918e755de1ef0cc8a7ad8e2efd9959bfeffaa;p=profile%2Fmobile%2Fapps%2Fnative%2Fmusic-player.git [TSAM-11769] Fixed double free issue Change-Id: Id7758061cf950daa0e81b0597bd980e06576d2f3 Signed-off-by: bhutani.92 --- diff --git a/src/common/mp-common.c b/src/common/mp-common.c index 92de486..b9c626c 100644 --- a/src/common/mp-common.c +++ b/src/common/mp-common.c @@ -1471,7 +1471,6 @@ void mp_common_playlist_album_update(mp_media_info_h playlist_handle) mp_media_info_playlist_set_thumbnail_path(playlist_handle, path); mp_media_info_list_destroy(svc_handle); - IF_FREE(path); } void diff --git a/src/view/mp-player-view.c b/src/view/mp-player-view.c index 108fe95..15f4739 100644 --- a/src/view/mp-player-view.c +++ b/src/view/mp-player-view.c @@ -954,46 +954,12 @@ static void _mp_player_view_queue_add_to_playlist_cb(void *data, mp_list_view_set_cancel_btn((MpListView_t *) edit_view, true); } -/*static void _mp_player_view_queue_save_as_to_playlist_cb(void *data, Evas_Object *obj, void *event_info) -{ - eventfunc; - - MpPlayerView_t *view = (MpPlayerView_t *) data; - MP_CHECK(view); - - mp_evas_object_del(view->more_btn_ctxpopup); - - Mp_Playlist_Data *mp_playlist_data = mp_edit_playlist_create(MP_PLST_SAVE_AS); - MP_CHECK(mp_playlist_data); - mp_edit_playlist_set_edit_list(mp_playlist_data, (MpList_t *)(view->queue_list)); - mp_edit_playlist_content_create(mp_playlist_data); - mp_edit_playlist_add_to_selected_mode(mp_playlist_data, false); -}*/ - -/*static void -_append_group_play_option(MpPlayerView_t *view, mp_track_info_t *track_info, bool playable) -{ - MP_CHECK(track_info); - - if (playable && track_info->track_type == MP_TRACK_URI) - { - char *mime = mp_util_file_mime_type_get(track_info->uri); - DEBUG_TRACE("mime: %s", mime); - if (!g_strcmp0(mime, "audio/x-wav")||!g_strcmp0(mime, "audio/mpeg")) - mp_util_ctxpopup_item_append(view->more_btn_ctxpopup, - STR_MP_PLAY_VIA_GROUP_PLAY, MP_PLAYER_MORE_BTN_GROUP_PLAY_IMAGE, _ctxpopup_group_play_cb, view); - IF_FREE(mime); - } -}*/ - static void _mp_player_view_add_cover_view_options(MpPlayerView_t * view, mp_track_info_t * track_info, bool playable) { /*enable set as only it's local file */ - /*_append_set_as_option(view, track_info, playable); - _append_group_play_option(view, track_info, playable);*/ mp_util_ctxpopup_item_append(view->more_btn_ctxpopup, STR_MP_ADD_TO_PLAYLIST, @@ -1030,16 +996,6 @@ static void _mp_player_view_add_radio_view_options(MpPlayerView_t * view) STR_MP_DETAILS, MP_PLAYER_MORE_BTN_CONN_INFO, _ctxpopup_detail_cb, view); - - /*mp_util_ctxpopup_item_append(view->more_btn_ctxpopup, - STR_MP_SETTINGS, MP_PLAYER_MORE_BTN_SETTING, _ctxpopup_setting_cb, view); */ - -} - -static void _mp_player_view_add_artist_view_options(MpPlayerView_t * view) -{ - /*mp_util_ctxpopup_item_append(view->more_btn_ctxpopup, - STR_MP_SETTINGS, MP_PLAYER_MORE_BTN_SETTING, _ctxpopup_setting_cb, view); */ } static void @@ -1126,8 +1082,6 @@ static void _mp_player_view_more_button_clicked_cb(void *data, playable); } else if (view->launch_type == MP_PLAYER_RADIO_PLAY) { _mp_player_view_add_radio_view_options(view); - } else if (view->launch_type == MP_PLAYER_ARTIST_PLAY) { - _mp_player_view_add_artist_view_options(view); } } #else