From: Hwankyu Jhun <h.jhun@samsung.com>
Date: Thu, 22 Jun 2023 01:55:07 +0000 (+0000)
Subject: Fix wrong sigchild handler
X-Git-Tag: accepted/tizen/unified/20230626.043751~7
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=6c22de6fcbb73202fd9e040e641d40d04d708d7b;p=platform%2Fcore%2Fappfw%2Flaunchpad.git

Fix wrong sigchild handler

The event listener should be called when getting the sigchld signal.

Change-Id: I9dc085b04237c1df3df84f73b1345032c4fe9cc3
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
---

diff --git a/src/launchpad-process-pool/sigchld_event.cc b/src/launchpad-process-pool/sigchld_event.cc
index b53624b0..42aeec43 100644
--- a/src/launchpad-process-pool/sigchld_event.cc
+++ b/src/launchpad-process-pool/sigchld_event.cc
@@ -56,10 +56,10 @@ void SigchldEvent::OnIOEventReceived(int fd, int condition) {
     while ((child_pid = waitpid(-1, &status, WNOHANG)) > 0) {
       if (child_pid == child_pgid)
         killpg(child_pgid, SIGKILL);
-
-      if (listener_ != nullptr)
-        listener_->OnSigchld(child_pid, status);
     }
+
+    if (listener_ != nullptr)
+      listener_->OnSigchld(child_pid, status);
   } while (ret == 0);
 }
 
diff --git a/src/lib/launchpad-hydra/signal_manager.cc b/src/lib/launchpad-hydra/signal_manager.cc
index 71daa335..1c22c7fa 100644
--- a/src/lib/launchpad-hydra/signal_manager.cc
+++ b/src/lib/launchpad-hydra/signal_manager.cc
@@ -120,10 +120,10 @@ void SignalManager::OnIOEventReceived(int fd, uint32_t revents) {
     while ((child_pid = waitpid(-1, &status, WNOHANG)) > 0) {
       if (child_pid == child_pgid)
         killpg(child_pgid, SIGKILL);
-
-      if (listener_ != nullptr)
-        listener_->OnSigchldReceived(child_pid, status);
     }
+
+    if (listener_ != nullptr)
+      listener_->OnSigchldReceived(child_pid, status);
   } while (ret == 0);
 }