From: Dan Carpenter <error27@gmail.com>
Date: Wed, 22 Feb 2023 15:17:06 +0000 (+0300)
Subject: firmware: arm_scmi: Return a literal instead of a variable
X-Git-Tag: v6.6.7~3037^2^2~7
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=6bed395d7db2c039c0ef4123a379e27c528a3357;p=platform%2Fkernel%2Flinux-starfive.git

firmware: arm_scmi: Return a literal instead of a variable

In this context "return scmi_dev;" and "return NULL;" are equivalent
but it is more readable to return a literal.

Signed-off-by: Dan Carpenter <error27@gmail.com>
Reviewed-by: Cristian Marussi <cristian.marussi@arm.com>
Link: https://lore.kernel.org/r/Y/Yx8pOdf8rNhPVe@kili
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
---

diff --git a/drivers/firmware/arm_scmi/bus.c b/drivers/firmware/arm_scmi/bus.c
index 73140b8..ac306ca 100644
--- a/drivers/firmware/arm_scmi/bus.c
+++ b/drivers/firmware/arm_scmi/bus.c
@@ -436,7 +436,7 @@ struct scmi_device *scmi_device_create(struct device_node *np,
 	/* Nothing to do. */
 	if (!phead) {
 		mutex_unlock(&scmi_requested_devices_mtx);
-		return scmi_dev;
+		return NULL;
 	}
 
 	/* Walk the list of requested devices for protocol and create them */