From: yangguo@chromium.org Date: Thu, 10 Nov 2011 14:13:32 +0000 (+0000) Subject: MIPS: Fixed a bug in StringHelper::GenerateTwoCharacterSymbolTableProbe. X-Git-Tag: upstream/4.7.83~17942 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=6bd8d27a654a01d79c14a165f40b9716328e9ea1;p=platform%2Fupstream%2Fv8.git MIPS: Fixed a bug in StringHelper::GenerateTwoCharacterSymbolTableProbe. r9871 (5baeaf57) changed the fill value for deleted entries in hash tables from null_value to the_hole_value. This commit changes an assertion in MIPS code that expects this value. BUG= TEST= Review URL: http://codereview.chromium.org/8479028 Patch from Gergely Kis . git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@9955 ce2b1a6d-e550-0410-aec6-3dcde31c8c00 --- diff --git a/src/mips/code-stubs-mips.cc b/src/mips/code-stubs-mips.cc index b40ab16..c45b8a5 100644 --- a/src/mips/code-stubs-mips.cc +++ b/src/mips/code-stubs-mips.cc @@ -5776,10 +5776,10 @@ void StringHelper::GenerateTwoCharacterSymbolTableProbe(MacroAssembler* masm, __ Branch(&is_string, ne, scratch, Operand(ODDBALL_TYPE)); __ Branch(not_found, eq, undefined, Operand(candidate)); - // Must be null (deleted entry). + // Must be the hole value (deleted entry). if (FLAG_debug_code) { - __ LoadRoot(scratch, Heap::kNullValueRootIndex); - __ Assert(eq, "oddball in symbol table is not undefined or null", + __ LoadRoot(scratch, Heap::kTheHoleValueRootIndex); + __ Assert(eq, "oddball in symbol table is not undefined or the hole value", scratch, Operand(candidate)); } __ jmp(&next_probe[i]);