From: Salim Fadhley <sal@stodge.org>
Date: Sun, 16 Jun 2013 23:37:28 +0000 (+0100)
Subject: corrected one of the api-methods
X-Git-Tag: v0.2.23~161^2~4
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=6b8c97331fc58d9fea43ac88b1706cbd590f1f08;p=tools%2Fpython-jenkinsapi.git

corrected one of the api-methods
---

diff --git a/jenkinsapi/api.py b/jenkinsapi/api.py
index 887c396..124e70f 100644
--- a/jenkinsapi/api.py
+++ b/jenkinsapi/api.py
@@ -122,7 +122,7 @@ def get_view_from_url(url):
         raise BadURL("Cannot parse URL %s" % url)
     jenkinsurl, view_name = matched.groups()
     jenkinsci = Jenkins(jenkinsurl)
-    return jenkinsci.get_view(view_name)
+    return jenkinsci.views()[view_name]
 
 def get_nested_view_from_url(url):
     """
diff --git a/jenkinsapi_tests/systests/test_views.py b/jenkinsapi_tests/systests/test_views.py
index 00a3afe..e1a0e74 100644
--- a/jenkinsapi_tests/systests/test_views.py
+++ b/jenkinsapi_tests/systests/test_views.py
@@ -3,7 +3,9 @@ System tests for `jenkinsapi.jenkins` module.
 '''
 import logging
 import unittest
+
 from jenkinsapi.view import View
+from jenkinsapi.api import get_view_from_url
 from jenkinsapi_tests.systests.base import BaseSystemTest
 from jenkinsapi_tests.test_utils.random_strings import random_string
 
@@ -19,10 +21,15 @@ class TestViews(BaseSystemTest):
         self.assertIn(view_name, self.jenkins.views())
         self.assertIsInstance(v, View)
 
+        # Can we use the API comnvenience methods
+        v2 = get_view_from_url(v.baseurl)
+        self.assertEquals(v, v2)
+
     def test_create_and_delete_views(self):
         self._create_job()
         view1_name = random_string()
         new_view = self.jenkins.views().create(view1_name)
+        self.assertIsInstance(new_view, View)
         self.assertIn(view1_name, self.jenkins.views())
         del self.jenkins.views()[view1_name]
         self.assertNotIn(view1_name, self.jenkins.views())