From: Mark Brown <broonie@kernel.org>
Date: Mon, 20 Jun 2016 12:53:32 +0000 (+0100)
Subject: iio:ad7266: Fix broken regulator error handling
X-Git-Tag: v4.14-rc1~2948^2^2~2
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=6b7f4e25f3309f106a5c7ff42c8231494cf285d3;p=platform%2Fkernel%2Flinux-rpi.git

iio:ad7266: Fix broken regulator error handling

All regulator_get() variants return either a pointer to a regulator or an
ERR_PTR() so testing for NULL makes no sense and may lead to bugs if we
use NULL as a valid regulator. Fix this by using IS_ERR() as expected.

Signed-off-by: Mark Brown <broonie@kernel.org>
Cc: <Stable@vger.kernel.org>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
---

diff --git a/drivers/iio/adc/ad7266.c b/drivers/iio/adc/ad7266.c
index 21e19b6..835d45d 100644
--- a/drivers/iio/adc/ad7266.c
+++ b/drivers/iio/adc/ad7266.c
@@ -397,7 +397,7 @@ static int ad7266_probe(struct spi_device *spi)
 	st = iio_priv(indio_dev);
 
 	st->reg = devm_regulator_get(&spi->dev, "vref");
-	if (!IS_ERR_OR_NULL(st->reg)) {
+	if (!IS_ERR(st->reg)) {
 		ret = regulator_enable(st->reg);
 		if (ret)
 			return ret;