From: Mike Blumenkrantz Date: Fri, 17 Jul 2015 20:08:37 +0000 (-0400) Subject: do not set opaque regions on comp object mirrors X-Git-Tag: upstream/0.20.0~547 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=6b7ce9137349cea65f30a7a45a9989aefcd6129c;p=platform%2Fupstream%2Fenlightenment.git do not set opaque regions on comp object mirrors based on testing, this breaks all rendering of related objects. I suspect that the image border needs to be manually scaled based on image::mirror proportions in order for this to work as expected, but adding the required code seems like too much complexity for nearly zero gain --- diff --git a/src/bin/e_comp_object.c b/src/bin/e_comp_object.c index 0192d5c..ae9218a 100644 --- a/src/bin/e_comp_object.c +++ b/src/bin/e_comp_object.c @@ -3373,7 +3373,8 @@ e_comp_object_dirty(Evas_Object *obj) eina_tiler_area_size_set(cw->pending_updates, w, h); EINA_LIST_FOREACH(cw->obj_mirror, ll, o) { - evas_object_image_border_set(o, bx, by, bxx, byy); + //evas_object_image_border_set(o, bx, by, bxx, byy); + //evas_object_image_border_center_fill_set(o, EVAS_BORDER_FILL_SOLID); evas_object_image_pixels_dirty_set(o, dirty); if (!dirty) evas_object_image_data_set(o, NULL); @@ -3577,16 +3578,17 @@ e_comp_object_util_mirror_add(Evas_Object *obj) } { Eina_Bool dirty; - int bx, by, bxx, byy; + //int bx, by, bxx, byy; dirty = evas_object_image_pixels_dirty_get(cw->obj); evas_object_image_pixels_dirty_set(o, dirty); - e_pixmap_image_opaque_get(cw->ec->pixmap, &bx, &by, &bxx, &byy); - if (bxx && byy) - bxx = cw->ec->client.w - (bx + bxx), byy = cw->ec->client.h - (by + byy); - else - bx = by = bxx = byy = 0; - evas_object_image_border_set(o, bx, by, bxx, byy); + //e_pixmap_image_opaque_get(cw->ec->pixmap, &bx, &by, &bxx, &byy); + //if (bxx && byy) + //bxx = cw->ec->client.w - (bx + bxx), byy = cw->ec->client.h - (by + byy); + //else + //bx = by = bxx = byy = 0; + //evas_object_image_border_set(o, bx, by, bxx, byy); + //evas_object_image_border_center_fill_set(o, EVAS_BORDER_FILL_SOLID); if (dirty) evas_object_image_data_update_add(o, 0, 0, w, h); evas_object_image_data_set(o, pix);