From: Tim-Philipp Müller <tim@centricular.net>
Date: Fri, 16 Aug 2013 15:45:41 +0000 (+0100)
Subject: queue2: don't crash on EOS if queue is empty
X-Git-Tag: 1.1.4~23
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=6b4bef214b48a52366c5382cc052fb3f70754b8a;p=platform%2Fupstream%2Fgstreamer.git

queue2: don't crash on EOS if queue is empty

Fixes spurious crash in test_simple_shutdown_while_running
unit test.
---

diff --git a/plugins/elements/gstqueue2.c b/plugins/elements/gstqueue2.c
index 43a0d4f..2ed5475 100644
--- a/plugins/elements/gstqueue2.c
+++ b/plugins/elements/gstqueue2.c
@@ -2072,6 +2072,10 @@ gst_queue2_locked_dequeue (GstQueue2 * queue, GstQueue2ItemType * item_type)
     item = gst_queue2_read_item_from_file (queue);
   } else {
     GstQueue2Item *qitem = g_queue_pop_head (&queue->queue);
+
+    if (qitem == NULL)
+      goto no_item;
+
     item = qitem->item;
     g_slice_free (GstQueue2Item, qitem);
   }