From: Pavel Labath <pavel@labath.sk>
Date: Tue, 10 Mar 2020 13:31:03 +0000 (+0100)
Subject: [lldb] Improve test failure messages in vscode tests
X-Git-Tag: llvmorg-12-init~12510
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=6b37c476a2d4e63f6c02ca8996e0e92ae3db3282;p=platform%2Fupstream%2Fllvm.git

[lldb] Improve test failure messages in vscode tests

A couple of tests sporadically fail on these assertions, but the error
messages do not give a clue as to what has actually happened.

Improve them so that we can better understand what is going wrong.
---

diff --git a/lldb/packages/Python/lldbsuite/test/tools/lldb-vscode/lldbvscode_testcase.py b/lldb/packages/Python/lldbsuite/test/tools/lldb-vscode/lldbvscode_testcase.py
index 1eb23ce..54f09e2 100644
--- a/lldb/packages/Python/lldbsuite/test/tools/lldb-vscode/lldbvscode_testcase.py
+++ b/lldb/packages/Python/lldbsuite/test/tools/lldb-vscode/lldbvscode_testcase.py
@@ -230,11 +230,11 @@ class VSCodeTestCaseBase(TestBase):
     def continue_to_exit(self, exitCode=0):
         self.vscode.request_continue()
         stopped_events = self.vscode.wait_for_stopped()
-        self.assertTrue(len(stopped_events) == 1,
-                        "expecting single 'exited' event")
-        self.assertTrue(stopped_events[0]['event'] == 'exited',
+        self.assertEquals(len(stopped_events), 1,
+                        "stopped_events = {}".format(stopped_events))
+        self.assertEquals(stopped_events[0]['event'], 'exited',
                         'make sure program ran to completion')
-        self.assertTrue(stopped_events[0]['body']['exitCode'] == exitCode,
+        self.assertEquals(stopped_events[0]['body']['exitCode'], exitCode,
                         'exitCode == %i' % (exitCode))
 
     def attach(self, program=None, pid=None, waitFor=None, trace=None,