From: Mark Nauwelaerts Date: Tue, 11 Nov 2008 19:24:12 +0000 (+0000) Subject: gst/quicktime/gstqtmux.c: Add some more safety/sanity checks in tag manipulation. X-Git-Tag: RELEASE-0.10.29~230 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=6b15001dc5d32f44745f5112e19ddcc16e35fddb;p=platform%2Fupstream%2Fgst-plugins-good.git gst/quicktime/gstqtmux.c: Add some more safety/sanity checks in tag manipulation. Original commit message from CVS: * gst/quicktime/gstqtmux.c: (gst_qt_mux_add_metadata_tags): Add some more safety/sanity checks in tag manipulation. --- diff --git a/gst/quicktime/gstqtmux.c b/gst/quicktime/gstqtmux.c index 9a181aa..7eaf730 100644 --- a/gst/quicktime/gstqtmux.c +++ b/gst/quicktime/gstqtmux.c @@ -360,9 +360,9 @@ gst_qt_mux_add_metadata_tags (GstQTMux * qtmux, const GstTagList * list) /* strings */ case G_TYPE_STRING: { - gchar *str; + gchar *str = NULL; - if (!gst_tag_list_get_string (list, tag, &str)) + if (!gst_tag_list_get_string (list, tag, &str) || !str) break; GST_DEBUG_OBJECT (qtmux, "Adding tag %" GST_FOURCC_FORMAT " -> %s", GST_FOURCC_ARGS (fourcc), str); @@ -400,13 +400,13 @@ gst_qt_mux_add_metadata_tags (GstQTMux * qtmux, const GstTagList * list) default: { if (gst_tag_get_type (tag) == GST_TYPE_DATE) { - GDate *date; + GDate *date = NULL; GDateYear year; GDateMonth month; GDateDay day; gchar *str; - if (!gst_tag_list_get_date (list, tag, &date)) + if (!gst_tag_list_get_date (list, tag, &date) || !date) break; year = g_date_get_year (date); month = g_date_get_month (date);