From: Johannes Berg <johannes.berg@intel.com>
Date: Fri, 9 Nov 2018 10:13:15 +0000 (+0100)
Subject: mac80211: sta_info: avoid tidstats variable shadowing
X-Git-Tag: v5.4-rc1~1957^2~46^2~41
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=6af8354f1db95a01a1ca0638868367d7fa7b6324;p=platform%2Fkernel%2Flinux-rpi.git

mac80211: sta_info: avoid tidstats variable shadowing

We have a pointer called 'tidstats' that shadows a bool function
argument with the same name, but we actually only use it once so
just remove the pointer.

Signed-off-by: Johannes Berg <johannes.berg@intel.com>
---

diff --git a/net/mac80211/sta_info.c b/net/mac80211/sta_info.c
index fb8c225..11b7ae6 100644
--- a/net/mac80211/sta_info.c
+++ b/net/mac80211/sta_info.c
@@ -2253,11 +2253,8 @@ void sta_set_sinfo(struct sta_info *sta, struct station_info *sinfo,
 	}
 
 	if (tidstats && !cfg80211_sinfo_alloc_tid_stats(sinfo, GFP_KERNEL)) {
-		for (i = 0; i < IEEE80211_NUM_TIDS + 1; i++) {
-			struct cfg80211_tid_stats *tidstats = &sinfo->pertid[i];
-
-			sta_set_tidstats(sta, tidstats, i);
-		}
+		for (i = 0; i < IEEE80211_NUM_TIDS + 1; i++)
+			sta_set_tidstats(sta, &sinfo->pertid[i], i);
 	}
 
 	if (ieee80211_vif_is_mesh(&sdata->vif)) {