From: Ming Lei Date: Sat, 3 Nov 2012 09:48:16 +0000 (+0800) Subject: firmware loader: document firmware cache mechanism X-Git-Tag: upstream/snapshot3+hdmi~6137^2~84 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=6a927857d890658789e6e54b058ef8527de8200a;p=platform%2Fadaptation%2Frenesas_rcar%2Frenesas_kernel.git firmware loader: document firmware cache mechanism This patch documents the firmware cache mechanism so that users of request_firmware() know that it can be called safely inside device's suspend and resume callback, and the device's firmware needn't be cached any more by individual driver itself to deal with firmware loss during system resume. Signed-off-by: Ming Lei Signed-off-by: Greg Kroah-Hartman --- diff --git a/Documentation/firmware_class/README b/Documentation/firmware_class/README index e9fce78..43fada9 100644 --- a/Documentation/firmware_class/README +++ b/Documentation/firmware_class/README @@ -119,3 +119,10 @@ on the setup, so I think that the choice on what firmware to make persistent should be left to userspace. + about firmware cache: + -------------------- + After firmware cache mechanism is introduced during system sleep, + request_firmware can be called safely inside device's suspend and + resume callback, and callers need't cache the firmware by + themselves any more for dealing with firmware loss during system + resume. diff --git a/drivers/base/firmware_class.c b/drivers/base/firmware_class.c index 7888af7..d814603 100644 --- a/drivers/base/firmware_class.c +++ b/drivers/base/firmware_class.c @@ -988,6 +988,9 @@ err_put_dev: * firmware image for this or any other device. * * Caller must hold the reference count of @device. + * + * The function can be called safely inside device's suspend and + * resume callback. **/ int request_firmware(const struct firmware **firmware_p, const char *name,