From: Carsten Haitzler (Rasterman) Date: Sun, 23 Jul 2017 09:43:58 +0000 (+0900) Subject: eina debug - add comments to cpu debug using locks to pause sysmon X-Git-Tag: upstream/1.20.0~155 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=6a65cb2f3c294e49dfe6dc895519eb08873bdb2b;p=platform%2Fupstream%2Fefl.git eina debug - add comments to cpu debug using locks to pause sysmon this is intended so leave comments saying so. coverity doesn't like it with CID 1377549 --- diff --git a/src/lib/eina/eina_debug_cpu.c b/src/lib/eina/eina_debug_cpu.c index f7cb2cc..0f25b4b 100644 --- a/src/lib/eina/eina_debug_cpu.c +++ b/src/lib/eina/eina_debug_cpu.c @@ -261,6 +261,7 @@ _cpufreq_on_cb(Eina_Debug_Session *session EINA_UNUSED, int cid EINA_UNUSED, voi { _eina_debug_sysmon_reset = 1; _eina_debug_sysmon_active = 1; + // this is intended. taking this lock allows sysmon to run eina_lock_release(&_sysmon_lock); } return EINA_TRUE; @@ -271,6 +272,7 @@ _cpufreq_off_cb(Eina_Debug_Session *session EINA_UNUSED, int cid EINA_UNUSED, vo { if (_eina_debug_sysmon_active) { + // this is intended. taking this lock blocks sysmod from running eina_lock_take(&_sysmon_lock); _eina_debug_sysmon_active = 0; }