From: Martin Kaiser Date: Sun, 2 Jul 2023 17:35:03 +0000 (+0200) Subject: hwrng: nomadik - use dev_err_probe X-Git-Tag: v6.6.17~4031^2~121 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=6a52ee38c79825ef469ab3ed8588d17e90d2049c;p=platform%2Fkernel%2Flinux-rpi.git hwrng: nomadik - use dev_err_probe Use dev_err_probe to print a message and return an error. This makes the code a tiny bit shorter. Signed-off-by: Martin Kaiser Signed-off-by: Herbert Xu --- diff --git a/drivers/char/hw_random/nomadik-rng.c b/drivers/char/hw_random/nomadik-rng.c index 3774adf..8c6a40d 100644 --- a/drivers/char/hw_random/nomadik-rng.c +++ b/drivers/char/hw_random/nomadik-rng.c @@ -39,11 +39,8 @@ static int nmk_rng_probe(struct amba_device *dev, const struct amba_id *id) int ret; rng_clk = devm_clk_get_enabled(&dev->dev, NULL); - if (IS_ERR(rng_clk)) { - dev_err(&dev->dev, "could not get rng clock\n"); - ret = PTR_ERR(rng_clk); - return ret; - } + if (IS_ERR(rng_clk)) + return dev_err_probe(&dev->dev, PTR_ERR(rng_clk), "could not get rng clock\n"); ret = amba_request_regions(dev, dev->dev.init_name); if (ret)