From: Dan Carpenter Date: Wed, 6 Jun 2012 14:15:33 +0000 (-0500) Subject: rbd: endian bug in rbd_req_cb() X-Git-Tag: v3.5~7^2 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=6a3ca4f18873f950895cb64ddefafb51a732e3f7;p=profile%2Fivi%2Fkernel-x86-ivi.git rbd: endian bug in rbd_req_cb() Sparse complains about this because: drivers/block/rbd.c:996:20: warning: cast to restricted __le32 drivers/block/rbd.c:996:20: warning: cast from restricted __le16 These are set in osd_req_encode_op() and they are le16. Signed-off-by: Dan Carpenter Reviewed-by: Alex Elder (cherry picked from commit 895cfcc810e53d7d36639969c71efb9087221167) --- diff --git a/drivers/block/rbd.c b/drivers/block/rbd.c index 8b9c173..8f428a8 100644 --- a/drivers/block/rbd.c +++ b/drivers/block/rbd.c @@ -977,7 +977,7 @@ static void rbd_req_cb(struct ceph_osd_request *req, struct ceph_msg *msg) op = (void *)(replyhead + 1); rc = le32_to_cpu(replyhead->result); bytes = le64_to_cpu(op->extent.length); - read_op = (le32_to_cpu(op->op) == CEPH_OSD_OP_READ); + read_op = (le16_to_cpu(op->op) == CEPH_OSD_OP_READ); dout("rbd_req_cb bytes=%lld readop=%d rc=%d\n", bytes, read_op, rc);