From: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: Fri, 24 Feb 2012 11:15:21 +0000 (+0000)
Subject: _dbus_transport_new_for_tcp_socket: add missing commas to address
X-Git-Tag: dbus-1.6.0~3
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=6a2af7b9a965c4a598ef2ace29b11b006b2c6b0a;p=platform%2Fupstream%2Fdbus.git

_dbus_transport_new_for_tcp_socket: add missing commas to address

Ralf pointed out that the address doesn't round-trip correctly.

Bug: https://bugs.freedesktop.org/show_bug.cgi?id=45896
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Reviewed-by: Ralf Habacker <ralf.habacker@freenet.de>
Tested-by: Ralf Habacker <ralf.habacker@freenet.de>
---

diff --git a/dbus/dbus-transport-socket.c b/dbus/dbus-transport-socket.c
index 0673a8c..544d00a 100644
--- a/dbus/dbus-transport-socket.c
+++ b/dbus/dbus-transport-socket.c
@@ -1337,12 +1337,12 @@ _dbus_transport_new_for_tcp_socket (const char     *host,
     goto error;
 
   if (family != NULL &&
-      (!_dbus_string_append (&address, "family=") ||
+      (!_dbus_string_append (&address, ",family=") ||
        !_dbus_string_append (&address, family)))
     goto error;
 
   if (noncefile != NULL &&
-      (!_dbus_string_append (&address, "noncefile=") ||
+      (!_dbus_string_append (&address, ",noncefile=") ||
        !_dbus_string_append (&address, noncefile)))
     goto error;