From: Alan Date: Wed, 17 Feb 2016 14:20:46 +0000 (+0000) Subject: i915: cast before shifting in i915_pte_count X-Git-Tag: v4.6-rc1~12^2~22^2~34 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=69603dbb315fc7a2b855990ee308b97dc23bf6eb;p=platform%2Fkernel%2Flinux-exynos.git i915: cast before shifting in i915_pte_count Otherwise a pde_shift big enough to overflow a u32 will be truncated before assignment Note: We never asked for ranges spanning a 4G boundary, so this issue doesn't cause a real problem. Signed-off-by: Alan Cox [danvet: Add note why this isn't a real problem.] Signed-off-by: Daniel Vetter Link: http://patchwork.freedesktop.org/patch/msgid/20160217142043.4947.60447.stgit@localhost.localdomain --- diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.h b/drivers/gpu/drm/i915/i915_gem_gtt.h index 66a6da2..368d111 100644 --- a/drivers/gpu/drm/i915/i915_gem_gtt.h +++ b/drivers/gpu/drm/i915/i915_gem_gtt.h @@ -418,7 +418,7 @@ static inline uint32_t i915_pte_index(uint64_t address, uint32_t pde_shift) static inline uint32_t i915_pte_count(uint64_t addr, size_t length, uint32_t pde_shift) { - const uint64_t mask = ~((1 << pde_shift) - 1); + const uint64_t mask = ~((1ULL << pde_shift) - 1); uint64_t end; WARN_ON(length == 0);