From: Mauro Carvalho Chehab Date: Wed, 29 Apr 2015 18:00:30 +0000 (-0300) Subject: [media] redrat3: change return argument on redrat3_send_cmd() to int X-Git-Tag: v4.14-rc1~4413^2~939 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=6948524d577dcad963bcdfcbf6e7d934cd18b8f7;p=platform%2Fkernel%2Flinux-rpi.git [media] redrat3: change return argument on redrat3_send_cmd() to int redrat3_send_cmd() can return an error or the read data. However, it currently returns an u8, as reported by smatch: drivers/media/rc/redrat3.c:416 redrat3_send_cmd() warn: signedness bug returning '(-12)' Signed-off-by: Mauro Carvalho Chehab --- diff --git a/drivers/media/rc/redrat3.c b/drivers/media/rc/redrat3.c index c4def66..c83292ad 100644 --- a/drivers/media/rc/redrat3.c +++ b/drivers/media/rc/redrat3.c @@ -405,7 +405,7 @@ static void redrat3_process_ir_data(struct redrat3_dev *rr3) } /* Util fn to send rr3 cmds */ -static u8 redrat3_send_cmd(int cmd, struct redrat3_dev *rr3) +static int redrat3_send_cmd(int cmd, struct redrat3_dev *rr3) { struct usb_device *udev; u8 *data;