From: Viresh Kumar Date: Mon, 9 Nov 2015 09:35:03 +0000 (+0530) Subject: greybus: es2: Send cport-id in wValue field to usb_control_msg() X-Git-Tag: v4.14-rc1~2366^2~378^2~21^2~1043 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=69166d252536b644f82782840cf31e6d685616dc;p=platform%2Fkernel%2Flinux-rpi.git greybus: es2: Send cport-id in wValue field to usb_control_msg() wIndex field has a special meaning, as that can be used by the core to index into the possible USB interfaces. And that specifically broke with gbsim, as it has a single USB interface. Other similar requests (REQUEST_LATENCY_TAG_{EN|DIS}) are already using wValue field for passing cport-id. Fix cport_reset() by sending the cport-id in wValue field instead of wIndex. Signed-off-by: Viresh Kumar Tested-by: Fabien Parent Reviewed-by: Johan Hovold Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/greybus/es2.c b/drivers/staging/greybus/es2.c index c1a6fe4..a0e2037 100644 --- a/drivers/staging/greybus/es2.c +++ b/drivers/staging/greybus/es2.c @@ -440,7 +440,7 @@ static int cport_reset(struct gb_host_device *hd, u16 cport_id) retval = usb_control_msg(udev, usb_sndctrlpipe(udev, 0), REQUEST_RESET_CPORT, USB_DIR_OUT | USB_TYPE_VENDOR | - USB_RECIP_INTERFACE, 0, cport_id, + USB_RECIP_INTERFACE, cport_id, 0, NULL, 0, ES2_TIMEOUT); if (retval < 0) { dev_err(&udev->dev, "failed to reset cport %hu: %d\n", cport_id,