From: peter klausler <pklausler@nvidia.com>
Date: Wed, 15 Jan 2020 00:16:32 +0000 (-0800)
Subject: [flang] Comments
X-Git-Tag: llvmorg-12-init~9537^2~194
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=68f021b8ac2ba64e68c816fb9d6fc56fac389414;p=platform%2Fupstream%2Fllvm.git

[flang] Comments

Original-commit: flang-compiler/f18@0c12188e8437abf820381fea787c625eda7e2d1f
Reviewed-on: https://github.com/flang-compiler/f18/pull/926
---

diff --git a/flang/lib/semantics/check-declarations.cc b/flang/lib/semantics/check-declarations.cc
index 500e135..752a73e 100644
--- a/flang/lib/semantics/check-declarations.cc
+++ b/flang/lib/semantics/check-declarations.cc
@@ -1051,7 +1051,7 @@ void CheckHelper::CheckEquivalenceSet(const EquivalenceSet &set) {
       if (&object != &*iter) {
         if (auto *details{object.symbol.detailsIf<ObjectEntityDetails>()}) {
           if (details->commonBlock()) {
-            if (details->commonBlock() != &commonBlock) {
+            if (details->commonBlock() != &commonBlock) {  // 8.10.3 paragraph 1
               if (auto *msg{messages_.Say(object.symbol.name(),
                       "Two objects in the same EQUIVALENCE set may not be members of distinct COMMON blocks"_err_en_US)}) {
                 msg->Attach(iter->symbol.name(),
@@ -1066,7 +1066,8 @@ void CheckHelper::CheckEquivalenceSet(const EquivalenceSet &set) {
             }
           } else {
             // Mark all symbols in the equivalence set with the same COMMON
-            // block
+            // block to prevent spurious error messages about initialization
+            // in BLOCK DATA outside COMMON
             details->set_commonBlock(commonBlock);
           }
         }