From: Uwe Kleine-König Date: Fri, 10 Jun 2022 21:12:53 +0000 (+0200) Subject: mmc: dw_mmc: exynos: Obviously always return success in remove callback X-Git-Tag: v6.1-rc5~705^2~37 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=68eab5176c71fe03ff37723a1c5cf20c26b06a99;p=platform%2Fkernel%2Flinux-starfive.git mmc: dw_mmc: exynos: Obviously always return success in remove callback dw_mci_pltfm_remove() returns 0 unconditionally and returning an error in a platform remove callback isn't very sensible. (The only effect of the latter is that the device core emits a generic warning and then removes the device anyhow.) So return 0 unconditionally to make it obvious there is no error forwarded to the upper layers. This is a preparation for making platform remove callbacks return void. Signed-off-by: Uwe Kleine-König Link: https://lore.kernel.org/r/20220610211257.102071-1-u.kleine-koenig@pengutronix.de Signed-off-by: Ulf Hansson --- diff --git a/drivers/mmc/host/dw_mmc-exynos.c b/drivers/mmc/host/dw_mmc-exynos.c index ca5be44..9f20ac5 100644 --- a/drivers/mmc/host/dw_mmc-exynos.c +++ b/drivers/mmc/host/dw_mmc-exynos.c @@ -670,7 +670,9 @@ static int dw_mci_exynos_remove(struct platform_device *pdev) pm_runtime_set_suspended(&pdev->dev); pm_runtime_put_noidle(&pdev->dev); - return dw_mci_pltfm_remove(pdev); + dw_mci_pltfm_remove(pdev); + + return 0; } static const struct dev_pm_ops dw_mci_exynos_pmops = {