From: Gilbok Lee <gilbok.lee@samsung.com>
Date: Mon, 6 Sep 2021 04:25:06 +0000 (+0900)
Subject: Fix Coverity issue
X-Git-Tag: accepted/tizen/unified/20210908.020325^0
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=68e724fab343bc64a63c868243ec2019e66c6829;p=platform%2Fcore%2Fmultimedia%2Fesplusplayer.git

Fix Coverity issue

Change-Id: I3b9b9f7edb3c239f25364a57f540dab44d8e162f
---

diff --git a/src/esplusplayer/src/esplayer.cpp b/src/esplusplayer/src/esplayer.cpp
index 794265a..6845018 100644
--- a/src/esplusplayer/src/esplayer.cpp
+++ b/src/esplusplayer/src/esplayer.cpp
@@ -336,6 +336,7 @@ bool EsPlayer::Activate(const StreamType type) {
       target->active = false;
       return false;
     }
+    std::lock_guard<std::mutex> lock2(eos_mutex_);
     eos_status_ =
         internal::ResetEosStatus(static_cast<TrackType>(type), eos_status_);
     return true;
@@ -599,6 +600,7 @@ bool EsPlayer::Seek(const uint64_t time_millisecond) {
   }
   LOG_DEBUG("[%p] > [ENTER] seek time [%" PRIu64 " ms]", this, time_millisecond);
   for (const auto& track : track_) {
+    std::lock_guard<std::mutex> lock2(eos_mutex_);
     eos_status_ = internal::ResetEosStatus(track.type, eos_status_);
     es_packet_logger_.PrintStoredPacketInfo(
         internal::ConvertToStreamType(track.type), true);
@@ -1239,6 +1241,7 @@ bool EsPlayer::Flush(const StreamType& type) {
                 state_manager_.GetStateEnum());
     return false;
   }
+  std::lock_guard<std::mutex> lock2(eos_mutex_);
   eos_status_ =
       internal::ResetEosStatus(static_cast<TrackType>(type), eos_status_);
   es_packet_logger_.ResetLog(type);
diff --git a/ut/src/esplusplayer/ut_basic.cpp b/ut/src/esplusplayer/ut_basic.cpp
index 3afc1d0..36caa4b 100644
--- a/ut/src/esplusplayer/ut_basic.cpp
+++ b/ut/src/esplusplayer/ut_basic.cpp
@@ -49,7 +49,10 @@ class EsBasicTest : public ::testing::TestWithParam<std::string> {
   ~EsBasicTest() { std::cout << "~EsBasicTest()" << std::endl; }
 
   static void SetUpTestCase() {
-    gst_init_check(nullptr, nullptr, nullptr);
+    if (!gst_init_check(nullptr, nullptr, nullptr)) {
+      std::cout << "gst init failed" << std::endl;
+      return;
+    }
     ESPacketDownloader::Init();
     std::cout << "SetUpTestCase()" << std::endl;
   }
diff --git a/ut/src/esplusplayer/ut_display.cpp b/ut/src/esplusplayer/ut_display.cpp
index b80e213..79132b3 100755
--- a/ut/src/esplusplayer/ut_display.cpp
+++ b/ut/src/esplusplayer/ut_display.cpp
@@ -51,7 +51,10 @@ class EsDisplayTest : public ::testing::TestWithParam<std::string> {
   ~EsDisplayTest() { std::cout << "~EsDisplayTest()" << std::endl; }
 
   static void SetUpTestCase() {
-    gst_init_check(nullptr, nullptr, nullptr);
+    if (!gst_init_check(nullptr, nullptr, nullptr)) {
+      std::cout << "gst init failed" << std::endl;
+      return;
+    }
     ESPacketDownloader::Init();
     std::cout << "SetUpTestCase()" << std::endl;
   }