From: Panu Matilainen <pmatilai@redhat.com>
Date: Wed, 25 Aug 2010 10:39:04 +0000 (+0300)
Subject: Eliminate ancient leftover initSourceHeader() call
X-Git-Tag: rpm-4.9.0-beta1~466
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=68beb82e9f1c4e828c4af460e68513090a3cd171;p=platform%2Fupstream%2Frpm.git

Eliminate ancient leftover initSourceHeader() call
- processSourceFiles() is only ever called through buildSpec(),
  and if you throw unparsed spec into that you're pretty much screwed
  anyway. rpmbuild always called initSourceHeader() anyway, and now
  its ensured for all successfully parsed specs.
---

diff --git a/build/files.c b/build/files.c
index 11efcbb..16d2cee 100644
--- a/build/files.c
+++ b/build/files.c
@@ -2065,13 +2065,6 @@ int processSourceFiles(rpmSpec spec)
     }
     sourceFiles = newStringBuf();
 
-    /* XXX
-     * XXX This is where the source header for noarch packages needs
-     * XXX to be initialized.
-     */
-    if (spec->sourceHeader == NULL)
-	initSourceHeader(spec);
-
     genSourceRpmName(spec);
     /* Construct the file list and source entries */
     appendLineStringBuf(sourceFiles, spec->specFile);