From: Marcin Kościelnicki Date: Wed, 2 Mar 2016 16:18:29 +0000 (+0100) Subject: [OBV] gdbserver: Only write ipa_tdesc_idx if agent is actually loaded. X-Git-Tag: binutils-2_27~1184 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=6896a8fa1e1d24a8fcc9b30efc0b195246b46029;p=external%2Fbinutils.git [OBV] gdbserver: Only write ipa_tdesc_idx if agent is actually loaded. Fixes rather embarassing gdb.trace regressions. gdb/gdbserver/ChangeLog: * tracepoint.c (cmd_qtstart): Only set ipa_tdesc_idx if agent is actually loaded. --- diff --git a/gdb/gdbserver/ChangeLog b/gdb/gdbserver/ChangeLog index 4c8df3f..40150d7 100644 --- a/gdb/gdbserver/ChangeLog +++ b/gdb/gdbserver/ChangeLog @@ -1,3 +1,8 @@ +2016-03-02 Marcin Kościelnicki + + * tracepoint.c (cmd_qtstart): Only set ipa_tdesc_idx if agent + is actually loaded. + 2016-02-25 Marcin Kościelnicki * linux-s390-low.c (s390_num_regs_3264): Define on 31-bit too. diff --git a/gdb/gdbserver/tracepoint.c b/gdb/gdbserver/tracepoint.c index dbd0b46..383fb71 100644 --- a/gdb/gdbserver/tracepoint.c +++ b/gdb/gdbserver/tracepoint.c @@ -3214,10 +3214,13 @@ cmd_qtstart (char *packet) *packet = '\0'; - /* Tell IPA about the correct tdesc. */ - if (write_inferior_integer (ipa_sym_addrs.addr_ipa_tdesc_idx, - target_get_ipa_tdesc_idx ())) - error ("Error setting ipa_tdesc_idx variable in lib"); + if (agent_loaded_p ()) + { + /* Tell IPA about the correct tdesc. */ + if (write_inferior_integer (ipa_sym_addrs.addr_ipa_tdesc_idx, + target_get_ipa_tdesc_idx ())) + error ("Error setting ipa_tdesc_idx variable in lib"); + } /* Start out empty. */ if (agent_loaded_p ())