From: Mike McLaughlin <mikem@microsoft.com>
Date: Thu, 27 Jun 2019 00:46:50 +0000 (-0700)
Subject: CR feedback
X-Git-Tag: submit/tizen/20190813.035844~4^2^2~19^2
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=6893d18cabb75768c0f409be78b401a9d8f1c119;p=platform%2Fcore%2Fdotnet%2Fdiagnostics.git

CR feedback
---

diff --git a/src/SOS/Strike/sos_stacktrace.h b/src/SOS/Strike/sos_stacktrace.h
index a9a54cf20..44599b328 100644
--- a/src/SOS/Strike/sos_stacktrace.h
+++ b/src/SOS/Strike/sos_stacktrace.h
@@ -166,14 +166,14 @@ HRESULT CALLBACK _EFN_GetManagedObjectFieldInfo(
     PULONG pOffset
     );
 
-// _EFN_GetManagedThread - return the managed thread object for the os thread id
+// _EFN_GetManagedThread - return the managed thread (Thread*) for the os thread id
 //
 // osThreadId - os thread id
-// pManagedObject - managed thread object returned
+// pManagedThread - managed thread returned
 HRESULT CALLBACK _EFN_GetManagedThread(
     PDEBUG_CLIENT client,
     ULONG osThreadId,
-    PULONG64 pManagedObject
+    PULONG64 pManagedThread
 );
 
 #ifdef __cplusplus
diff --git a/src/SOS/Strike/strike.cpp b/src/SOS/Strike/strike.cpp
index 92b48188c..9a298cf29 100644
--- a/src/SOS/Strike/strike.cpp
+++ b/src/SOS/Strike/strike.cpp
@@ -15379,13 +15379,13 @@ DECLARE_API(VerifyGMT)
             return Status;
         }
     }
-    ULONG64 managedObject;
-    HRESULT hr = _EFN_GetManagedThread(client, osThreadId, &managedObject);
+    ULONG64 managedThread;
+    HRESULT hr = _EFN_GetManagedThread(client, osThreadId, &managedThread);
     {
         INIT_API();
 
         if (SUCCEEDED(hr)) {
-            ExtOut("%08x %p\n", osThreadId, managedObject);
+            ExtOut("%08x %p\n", osThreadId, managedThread);
         }
         else {
             ExtErr("_EFN_GetManagedThread FAILED %08x\n", hr);
@@ -15398,12 +15398,12 @@ HRESULT CALLBACK
 _EFN_GetManagedThread(
     PDEBUG_CLIENT client,
     ULONG osThreadId,
-    PULONG64 pManagedObject)
+    PULONG64 pManagedThread)
 {
     INIT_API();
 
-    _ASSERTE(pManagedObject != nullptr);
-    *pManagedObject = 0;
+    _ASSERTE(pManagedThread != nullptr);
+    *pManagedThread = 0;
 
     DacpThreadStoreData threadStore;
     if ((Status = threadStore.Request(g_sos)) != S_OK)
@@ -15421,7 +15421,7 @@ _EFN_GetManagedThread(
         }        
         if (thread.osThreadId == osThreadId)
         {        
-            *pManagedObject = (ULONG64)curThread;
+            *pManagedThread = (ULONG64)curThread;
             return S_OK;
         }
         curThread = thread.nextThread;