From: bzcheeseman Date: Tue, 9 Aug 2022 15:11:13 +0000 (-0700) Subject: [Docs][CodeReview] Add a small paragraph on adding tokens, NFC. X-Git-Tag: upstream/17.0.6~34896 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=688178aa2bd3c8b333b1f6d859943ab580988a17;p=platform%2Fupstream%2Fllvm.git [Docs][CodeReview] Add a small paragraph on adding tokens, NFC. Reviewed By: whisperity Differential Revision: https://reviews.llvm.org/D131500 --- diff --git a/llvm/docs/CodeReview.rst b/llvm/docs/CodeReview.rst index a22141c..3bd305e 100644 --- a/llvm/docs/CodeReview.rst +++ b/llvm/docs/CodeReview.rst @@ -147,6 +147,12 @@ approved. If unsure, the reviewer should provide a qualified approval, (e.g., you are fairly certain that a particular community member will wish to review, even if that person hasn't done so yet. +If you approve of the idea/concept of a patch but feel unqualified to approve, +another option (other than accepting the patch) is to simply *"Award Token"* +(right-hand side in Phabricator) to indicate support without indicating to +other reviewers that the patch has been accepted and reviewed in their +dashboard. + Note that, if a reviewer has requested a particular community member to review, and after a week that community member has yet to respond, feel free to ping the patch (which literally means submitting a comment on the patch with the