From: Viresh Kumar Date: Fri, 22 Jul 2016 21:13:44 +0000 (-0700) Subject: greybus: bootrom: Rename download_firmware() as find_firmware() X-Git-Tag: v4.9.8~1233^2~378^2~21^2~110 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=68793c4c8824a0b1e0cb89737c5919a0b10d70cf;p=platform%2Fkernel%2Flinux-rpi3.git greybus: bootrom: Rename download_firmware() as find_firmware() The download_firmware() function isn't downloading the firmware but just finding if one is available or not. The same applies to the error message printed by it. Replace 'download' with 'find' to make it sound better. Reported-by: Johan Hovold Signed-off-by: Viresh Kumar Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/greybus/bootrom.c b/drivers/staging/greybus/bootrom.c index b90b25c..e7cfa80 100644 --- a/drivers/staging/greybus/bootrom.c +++ b/drivers/staging/greybus/bootrom.c @@ -140,7 +140,7 @@ static void bootrom_es2_fixup_vid_pid(struct gb_bootrom *bootrom) } /* This returns path of the firmware blob on the disk */ -static int download_firmware(struct gb_bootrom *bootrom, u8 stage) +static int find_firmware(struct gb_bootrom *bootrom, u8 stage) { struct gb_connection *connection = bootrom->connection; struct gb_interface *intf = connection->bundle->intf; @@ -177,8 +177,8 @@ static int download_firmware(struct gb_bootrom *bootrom, u8 stage) rc = request_firmware(&bootrom->fw, firmware_name, &connection->bundle->dev); if (rc) { - dev_err(&connection->bundle->dev, "failed to download %s firmware (%d)\n", - firmware_name, rc); + dev_err(&connection->bundle->dev, + "failed to find %s firmware (%d)\n", firmware_name, rc); } return rc; @@ -205,7 +205,7 @@ static int gb_bootrom_firmware_size_request(struct gb_operation *op) mutex_lock(&bootrom->mutex); - ret = download_firmware(bootrom, size_request->stage); + ret = find_firmware(bootrom, size_request->stage); if (ret) goto unlock;