From: Peter Maydell Date: Tue, 12 Jul 2016 12:02:12 +0000 (+0100) Subject: linux-user: Pass missing MAP_ANONYMOUS to target_mmap() call X-Git-Tag: TizenStudio_2.0_p2.3.2~9^2~14^2~5^2~173^2~17 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=68754b442b756e8cb5f143b00937fb7330a51a81;p=sdk%2Femulator%2Fqemu.git linux-user: Pass missing MAP_ANONYMOUS to target_mmap() call A target_mmap() call in load_elf_binary() was missing the MAP_ANONYMOUS flag. (Spotted by Coverity, because target_mmap() will try to use -1 as the filedescriptor in this case.) This has never been noticed because the code in question is for handling ancient SVr4 iBCS2 binaries. Signed-off-by: Peter Maydell Signed-off-by: Riku Voipio --- diff --git a/linux-user/elfload.c b/linux-user/elfload.c index 29455e4..e9a3882 100644 --- a/linux-user/elfload.c +++ b/linux-user/elfload.c @@ -2233,7 +2233,7 @@ int load_elf_binary(struct linux_binprm *bprm, struct image_info *info) we do not have the power to recompile these, we emulate the SVr4 behavior. Sigh. */ target_mmap(0, qemu_host_page_size, PROT_READ | PROT_EXEC, - MAP_FIXED | MAP_PRIVATE, -1, 0); + MAP_FIXED | MAP_PRIVATE | MAP_ANONYMOUS, -1, 0); } }