From: Aleksei Vereshchagin <avereschagin@dev.rtsoft.ru>
Date: Mon, 11 Dec 2017 17:19:28 +0000 (+0300)
Subject: Only S_OK hresult from GetModuleMetaData() guarantees return of valid pointer
X-Git-Tag: submit/tizen/20180619.075036~5
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=682a4f1422cb279b1c91e953b57abda51f05b8f8;p=sdk%2Ftools%2Fcoreprofiler.git

Only S_OK hresult from GetModuleMetaData() guarantees return of valid pointer
---

diff --git a/src/info/classinfo.cpp b/src/info/classinfo.cpp
index 1a40b23..bd603cc 100644
--- a/src/info/classinfo.cpp
+++ b/src/info/classinfo.cpp
@@ -367,7 +367,7 @@ __forceinline HRESULT ClassInfo::InitializeRegularClassName(
         hr = info.v1()->GetModuleMetaData(
             this->moduleId, ofRead, IID_IMetaDataImport,
             reinterpret_cast<IUnknown**>(&pMDImport));
-        if (FAILED(hr))
+        if (hr != S_OK)
         {
             throw HresultException(
                 "ClassInfo::InitializeRegularClassName(): "
diff --git a/src/info/functioninfo.cpp b/src/info/functioninfo.cpp
index 1cf211c..65e370b 100644
--- a/src/info/functioninfo.cpp
+++ b/src/info/functioninfo.cpp
@@ -793,7 +793,7 @@ HRESULT FunctionInfo::Initialize(
         hr = info.v1()->GetModuleMetaData(
             this->moduleId, ofRead, IID_IMetaDataImport,
             reinterpret_cast<IUnknown**>(&pMDImport));
-        if (FAILED(hr))
+        if (hr != S_OK)
         {
             throw HresultException(
                 "FunctionInfo::Initialize(): GetModuleMetaData()", hr);