From: Keith Busch <keith.busch@intel.com>
Date: Wed, 18 Nov 2015 23:33:08 +0000 (-0700)
Subject: NVMe: Fix possible arithmetic overflow for max segments
X-Git-Tag: v4.14-rc1~4262^2~15
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=6824c5ef5e8900e61ce8ed40885cacc1c9301c14;p=platform%2Fkernel%2Flinux-rpi.git

NVMe: Fix possible arithmetic overflow for max segments

Reported-by: Paul Grabinar <paul.grabinar@ranbarg.com>
Signed-off-by: Keith Busch <keith.busch@intel.com>
Signed-off-by: Jens Axboe <axboe@fb.com>
---

diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
index 8187df2..394fd16 100644
--- a/drivers/nvme/host/pci.c
+++ b/drivers/nvme/host/pci.c
@@ -2268,7 +2268,7 @@ static void nvme_alloc_ns(struct nvme_dev *dev, unsigned nsid)
 	if (dev->max_hw_sectors) {
 		blk_queue_max_hw_sectors(ns->queue, dev->max_hw_sectors);
 		blk_queue_max_segments(ns->queue,
-			((dev->max_hw_sectors << 9) / dev->page_size) + 1);
+			(dev->max_hw_sectors / (dev->page_size >> 9)) + 1);
 	}
 	if (dev->stripe_size)
 		blk_queue_chunk_sectors(ns->queue, dev->stripe_size >> 9);