From: David Sterba Date: Tue, 7 Jul 2020 16:30:06 +0000 (+0200) Subject: btrfs: clear defrag status of a root if starting transaction fails X-Git-Tag: v5.15~517^2~92 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=6819703f5a365c95488b07066a8744841bf14231;p=platform%2Fkernel%2Flinux-starfive.git btrfs: clear defrag status of a root if starting transaction fails The defrag loop processes leaves in batches and starting transaction for each. The whole defragmentation on a given root is protected by a bit but in case the transaction fails, the bit is not cleared In case the transaction fails the bit would prevent starting defragmentation again, so make sure it's cleared. CC: stable@vger.kernel.org # 4.4+ Reviewed-by: Qu Wenruo Reviewed-by: Anand Jain Signed-off-by: David Sterba --- diff --git a/fs/btrfs/transaction.c b/fs/btrfs/transaction.c index e0a82aa..2295162 100644 --- a/fs/btrfs/transaction.c +++ b/fs/btrfs/transaction.c @@ -1406,8 +1406,10 @@ int btrfs_defrag_root(struct btrfs_root *root) while (1) { trans = btrfs_start_transaction(root, 0); - if (IS_ERR(trans)) - return PTR_ERR(trans); + if (IS_ERR(trans)) { + ret = PTR_ERR(trans); + break; + } ret = btrfs_defrag_leaves(trans, root);