From: Marek Szyprowski Date: Mon, 9 Jan 2023 22:00:33 +0000 (+0100) Subject: drm/meson: dw-hdmi: Fix devm_regulator_*get_enable*() conversion X-Git-Tag: v6.6.7~1918^2~23^2~1030 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=67d0a30128c9f644595dfe67ac0fb941a716a6c9;p=platform%2Fkernel%2Flinux-starfive.git drm/meson: dw-hdmi: Fix devm_regulator_*get_enable*() conversion devm_regulator_get_enable_optional() function returns 0 on success, so use it for the check if function succeeded instead of the -ENODEV value. Fixes: 429e87063661 ("drm/meson: dw-hdmi: Use devm_regulator_*get_enable*()") Signed-off-by: Marek Szyprowski Acked-by: Neil Armstrong Signed-off-by: Neil Armstrong [narmstrong: s/succeeded/succeeded/ in commit message] Link: https://patchwork.freedesktop.org/patch/msgid/20230109220033.31202-1-m.szyprowski@samsung.com --- diff --git a/drivers/gpu/drm/meson/meson_dw_hdmi.c b/drivers/gpu/drm/meson/meson_dw_hdmi.c index 7642f74..534621a 100644 --- a/drivers/gpu/drm/meson/meson_dw_hdmi.c +++ b/drivers/gpu/drm/meson/meson_dw_hdmi.c @@ -718,7 +718,7 @@ static int meson_dw_hdmi_bind(struct device *dev, struct device *master, dw_plat_data = &meson_dw_hdmi->dw_plat_data; ret = devm_regulator_get_enable_optional(dev, "hdmi"); - if (ret != -ENODEV) + if (ret < 0) return ret; meson_dw_hdmi->hdmitx_apb = devm_reset_control_get_exclusive(dev,