From: Dan Carpenter Date: Sat, 27 Nov 2021 14:07:50 +0000 (+0300) Subject: pinctrl: mediatek: uninitialized variable in mtk_pctrl_show_one_pin() X-Git-Tag: v6.6.17~8434^2~32 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=67bbbcb49b968a93251de7b23616d5aff5d3a726;p=platform%2Fkernel%2Flinux-rpi.git pinctrl: mediatek: uninitialized variable in mtk_pctrl_show_one_pin() The "try_all_type" variable is not set if (hw->soc->pull_type) is false leading to the following Smatch warning: drivers/pinctrl/mediatek/pinctrl-paris.c:599 mtk_pctrl_show_one_pin() error: uninitialized symbol 'try_all_type'. Fixes: fb34a9ae383a ("pinctrl: mediatek: support rsel feature") Signed-off-by: Dan Carpenter Link: https://lore.kernel.org/r/20211127140750.GA24002@kili Signed-off-by: Linus Walleij --- diff --git a/drivers/pinctrl/mediatek/pinctrl-paris.c b/drivers/pinctrl/mediatek/pinctrl-paris.c index d4e02c5..4c6f6d9 100644 --- a/drivers/pinctrl/mediatek/pinctrl-paris.c +++ b/drivers/pinctrl/mediatek/pinctrl-paris.c @@ -581,7 +581,7 @@ ssize_t mtk_pctrl_show_one_pin(struct mtk_pinctrl *hw, { int pinmux, pullup, pullen, len = 0, r1 = -1, r0 = -1, rsel = -1; const struct mtk_pin_desc *desc; - u32 try_all_type; + u32 try_all_type = 0; if (gpio >= hw->soc->npins) return -EINVAL;